Skip to content

Conversation

@bmos
Copy link
Contributor

@bmos bmos commented Mar 11, 2025

To get this set up, a new GitHub Actions environment called "release" should be created.
This environment should be connected as a Trusted Publisher via pypi: https://docs.pypi.org/trusted-publishers/
I'm thinking re-implementing the build + pypi process should let us fix/render obsolete #1341

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@fgregg
Copy link
Contributor

fgregg commented Mar 27, 2025

do you even want there to be wheel distributions?

setup.py has conditional logic to allow for modular imports if an environmental variables is set. In order to take advantage of that, setup.py has to exist, and it won't in the wheel distributions.

@fgregg
Copy link
Contributor

fgregg commented Mar 27, 2025

this will not address #1341 because of the reasons given in #1341 (comment)

@bmos
Copy link
Contributor Author

bmos commented Apr 26, 2025

https://docs.astral.sh/uv/guides/package

Looks like maybe we can use uv for this?

@shaunagm
Copy link
Collaborator

shaunagm commented Jul 3, 2025

Okay, trusted publishing is set up and pointing at a currently-not-existent-in-main release.yml file. I think that means if we merge this, and then cut a new release, it will automatically get pushed to PyPI. Does that sound right? Are we missing anything?

Edit: also set up an environment named "release" for running release.yml in and configured it so a reviewer needs to approve it to run.

@shaunagm shaunagm marked this pull request as ready for review July 3, 2025 18:57
@shaunagm shaunagm merged commit b532f22 into move-coop:main Jul 3, 2025
70 checks passed
@bmos bmos deleted the patch-1 branch July 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants